[Bug 233070] gnome-web-photo: HTML pages thumbnailer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: gnome-web-photo: HTML pages thumbnailer


https://bugzilla.redhat.com/show_bug.cgi?id=233070


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora




------- Additional Comments From bnocera at redhat.com  2007-09-05 09:57 EST -------
(In reply to comment #2)
> Not a full review, but some comments from looking over the spec file:
> 
> * For your URL tag, Is there a specific reason for choosing the ftp.acc.umu.se
> mirror rather than the round-robin ftp.gnome.org hostname?

Fixed

> * Your Source0 tag should be a fully-qualified URL to the tarball; or if it's a
> Fedora-hosted project (wherein this packaging *is* the upstream source), you
> should add a comment to note it as such.

Fixed.

> * Does it really need the gettext development environment, or does it just use
> the gettext utilities for its translation merging while building? If it just
> uses the utilities, then please change the "BuildRequires: gettext-devel" to
> simply "BuildRequires: gettext"

gettext should be enough.

> * You don't need a build-time dependency on libpng-devel, since it's a
> dependency of gtk2-devel. Similarly, gnome-vfs2-devel has a depenency on
> GConf2-devel, so you should remove libpng-devel and GConf2-devel from your
> BuildRequires since they are duplicated entries.

Done.

Fixed packages at:
http://www.gnome.org/~hadess/gnome-web-photo/gnome-web-photo-0.3-2.src.rpm
http://www.gnome.org/~hadess/gnome-web-photo/gnome-web-photo.spec


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.