[Bug 233070] gnome-web-photo: HTML pages thumbnailer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: gnome-web-photo: HTML pages thumbnailer


https://bugzilla.redhat.com/show_bug.cgi?id=233070





------- Additional Comments From mclasen at redhat.com  2007-09-06 01:50 EST -------
formal review:

rpmlint: 
gnome-web-photo.i386: W: non-conffile-in-etc
/etc/gconf/schemas/gnome-web-photo.schemas

this follows existing practise, thus is ok


gnome-web-photo.i386: W: incoherent-version-in-changelog 0.3.2 0.3-2.fc8

should be fixed


gnome-web-photo.i386: W: invalid-license GPL

must be fixed (see below)


gnome-web-photo.src: W: mixed-use-of-spaces-and-tabs (spaces: line 38, tab: line 38)

unimportant


package name: ok
spec file name: ok  
packaging guidelines: 
  - I don't think there is any reason to use %{__rm}
  - You need a %postun for gconf schemas, I believe
  - The preferred form of the requires is perl(XML::Parser)
license: unclear, COPYING is GPLv2, but the sources all say LGPLv2+, 
  should be clarified upstream
license field: should be updated to match the result of aforementioned   
  clarification
license file: ok
spec file language: ok
spec file legibility: ok
upstream sources: ok
build: fails, see below
excludearch: n/a
build reqs: misses libjpeg-devel
%find_lang: ok
shared library symlinks: n/a
relocatable: n/a
directory ownership: ok
duplicate files: ok
file permissions: ok
%clean: ok
macro use: ok
permissible content: ok
large docs: n/a
%doc content: ok
header files: n/a
static libs: n/a
pc files: n/a
shared libs: n/a
devel package: n/a
libtool archives: n/a
gui apps: ok
directory ownership: ok
%install: ok
utf8 filenames: ok

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.