[Bug 260441] Review Request: pguiman - The PostgreSQL database server managing tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pguiman - The PostgreSQL database server managing tool


https://bugzilla.redhat.com/show_bug.cgi?id=260441





------- Additional Comments From mbarabas at redhat.com  2007-09-06 08:42 EST -------
* RPM name is OK
* Builds fine in mock
* File list looks OK
X Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
X rpmlint is not silent, see below
* dist tag is present.
* license field matches the actual license.
* %clean is present.
X sources are listed twice
  - Please remove Source0
* spec file for the package is legible
* package builds properly
* package installs properly
? package doesn't use locales
* no duplicates in %files.
* file permissions are appropriate.
* no -devel package
* no -docs subpackage is necessary
* no pkgconfig files
* good use of macros
* content is permissable
* %doc has no affect on runtime
* no static libraries present
X package owns directories already owned by aother package
  - Please remove %dir %{_datadir}/applications/ and %{_datadir}/pixmaps/
* package contains %{name}.desktop file, desktop-file-install command present


SHOULD:
X package doesn't contains LICENSE file
* no Non-English languages in description or summary
* build tested on mock-build x86_64 and i386
* tested functionaloty of package

rpmlint:
  W: pguiman-debuginfo spurious-executable-perm
/usr/src/debug/pguiman-0.0.1/src/database/create_db_objects.c
  W: pguiman-debuginfo spurious-executable-perm
/usr/src/debug/pguiman-0.0.1/src/tools/db_profile_manager.c
  W: pguiman-debuginfo spurious-executable-perm
/usr/src/debug/pguiman-0.0.1/src/GUI_db_objects/domain.c
  ...
  Simple solution: remove execution bit from all files *.c *.h

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.