[Bug 260441] Review Request: pguiman - The PostgreSQL database server managing tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pguiman - The PostgreSQL database server managing tool


https://bugzilla.redhat.com/show_bug.cgi?id=260441





------- Additional Comments From odvorace at redhat.com  2007-09-06 11:18 EST -------
Hi,
links to corrected spec file and srpm:
Spec URL:
http://pguiman.svn.sourceforge.net/viewvc/*checkout*/pguiman/trunk/pguiman.spec
SRPM URL: http://downloads.sourceforge.net/pguiman/pguiman-0.0.1-2.fc7.src.rpm

Comments:
MUST:
"X Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)"
## added SMP flags
"X sources are listed twice
  - Please remove Source0"
## left only sourceforge.net source
"X package owns directories already owned by aother package
  - Please remove %dir %{_datadir}/applications/ and %{_datadir}/pixmaps/"
## removed %dir %{_datadir}/applications/ and %dir %{_datadir}/pixmaps/ from
spec file

SHOULD:
"X package doesn't contains LICENSE file"
## the licence text is in the COPYING file

rpmlint:
"W: pguiman-debuginfo spurious-executable-perm
/usr/src/debug/pguiman-0.0.1/src/database/create_db_objects.c
  W: pguiman-debuginfo spurious-executable-perm
/usr/src/debug/pguiman-0.0.1/src/tools/db_profile_manager.c
  W: pguiman-debuginfo spurious-executable-perm
/usr/src/debug/pguiman-0.0.1/src/GUI_db_objects/domain.c
  ...
  Simple solution: remove execution bit from all files *.c *.h"
## removed execution bit from all files *.c *h

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.