[Bug 250924] Review Request: flashrom - Simple program for reading/writing BIOS chips content

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: flashrom - Simple program for reading/writing BIOS chips content


https://bugzilla.redhat.com/show_bug.cgi?id=250924


opensource at till.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |opensource at till.name
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From opensource at till.name  2007-09-06 11:50 EST -------
rpmlint: ok (silent)
naming: ok (no upstream versioning, yet, version 0 should not conflict with any
version)
license: ok (GPLv2+, license text not included, but refered to in source files)
spec legible: ok
source0: svn checkout, instructions included, tarball matches own export: ok
ExcludeArch: ppc, ppc64: bugs need to be filed against FE-ExcludeArch-ppc,
FE-ExcludeArch-ppc64 once the package is imported
BuildRequires: ok, builds in mock for i386, F7
no library / devel stuff: ok
directory ownage: ok
%files section: no duplicates, defattr specified:ok
rm -rf %{buildroot} in %install and %clean: ok
%changelog format: ok

APPROVED, don't forget to file bugs against the Excludearch blocker bugs.


Optional:
Can you ask upstream to add an license header to udelay.c and include a copy of
their license in the repository?

There are some build warnings that should be reported upstream:
layout.c: In function 'read_romlayout':                                        
                                                                           
layout.c:114: warning: ignoring return value of 'fscanf', declared with
attribute warn_unused_result 
flashrom.c: In function 'main':                                                
                                                                           
flashrom.c:402: warning: ignoring return value of 'fwrite', declared with
attribute warn_unused_result                                                   
  flashrom.c:421: warning: ignoring return value of 'fread', declared with
attribute warn_unused_result 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.