[Bug 251020] Review Request: libflaim - Flaim Database Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libflaim - Flaim Database Engine


https://bugzilla.redhat.com/show_bug.cgi?id=251020


opensource at till.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From opensource at till.name  2007-09-06 17:22 EST -------
- rpmlint: ok
W: libflaim-devel no-documentation

- naming: ok
- versioning: ok
- license: BAD/TODO
  License Tag ist LGPLv2 but license is GPLv2
  license text (GPLv2) is included and mentioned in source files
- rpm legible: ok
- source: ok
url points to correct file:
cbd0caf6239cffb7640391eda7551d4a  libflaim-4.9.989.tar.gz
cbd0caf6239cffb7640391eda7551d4a  libflaim-4.9.989.tar.gz.1
- builds in mock for F7, i386
- ldconfig run: ok
- directory ownage: ok
- buildroot: ok
- %files: no dupes and correct defattr: ok
- no -static needed: ok
- no libtool files: ok
- .so file without suffix in devel: ok
- %install and %clean with rm: ok
- -devel requires of mainpackage: ok

- todo before import:
* add a libflaim prefix to the patch, i.e. rename it to:
libflaim-permissions.patch

* fix license tag

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.