[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font


https://bugzilla.redhat.com/show_bug.cgi?id=266261





------- Additional Comments From opensource at till.name  2007-09-06 18:04 EST -------
- Conflicts should be ok. (see the previously mentioned thread)

- Building with mock gives an error:
+ install -m 0644 -p 'fonts/*.pcf.gz'
/var/tmp/knm_new-fonts-1.1-1.fc7-root-mockbuild/usr/share/fonts/knm_new-fonts/
install: cannot stat `fonts/*.pcf.gz': No such file or directory

this
install -m 0644 -p fonts/*.pcf.gz $RPM_BUILD_ROOT%{fontdir}/
should be changed to
install -m 0644 -p *.pcf.gz $RPM_BUILD_ROOT%{fontdir}/

- this should be removed because it is not used:
%define buildsubdir     %{name}-%{version}

- in %prep
instead of
%{__mkdir_p} $RPM_BUILD_DIR/%{name}-%{version}
cd $RPM_BUILD_DIR/%{name}-%{version}
tar xfz %{SOURCE0}
this should be used:
%setup -q -n fonts


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.