[Bug 226800] Review Request: emacs-bbdb - email database for Emacs

bugzilla at redhat.com bugzilla at redhat.com
Sun Sep 9 12:42:39 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: emacs-bbdb - email database for Emacs


https://bugzilla.redhat.com/show_bug.cgi?id=226800





------- Additional Comments From jonathan.underwood at gmail.com  2007-09-09 08:42 EST -------
(In reply to comment #21)
> Hi.  Sorry I've been ignoring this once again :(
> I think it would be fine for Jonathan to be the primary packager.
> 

Fine with me, but would very much welcome a co-maintaniner, hint hint :).

> I looked at the newest spec file and I read through the Emacs
> packaging draft.  Looking good!
> 

Thanks.

> Going back to the bbdb-autoloads.el question -- I think the reason that
> this is in site-start.d is so that the autoloads will be evaluated at
> Emacs startup (see site-lisp/site-start.el).  This means that the user
> doesn't have to add an explicit require or anything to their .emacs to
> start using BBDB.  I was wrong about this back in comment #10.  (FWIW
> this is mentioned in the packaging guidelines.)

Yes - actually the best way of dealing with this IMO is to add an init file to
site-lisp/site-start.d which does a (requires 'bbdb-autoloads) - that's what
most packages do, and is the spirit of the guidelines - have updated the spec
file to create such a file. Is this ok with you?

> 
> In my copy of the latest RPM, bbdb-autoloads.el ends up in site-lisp/bbdb/.
> So, I think it should be moved again.
> 

As I say above - I would prefer to leave bbdb-autoloads in the site-lisp/bbdb
directory, and add a file to site-lisp/site-start.d which requires bbdb-autolods

> BTW ... BBDB and VM requiring each other seems pretty ugly!  Perhaps one or
> the other could be fixed upstream.

Yeah, it's very horrible. Fortunately recently it has transpired that the same
person has taken over upstream leadership of both packages, so I will begin a
campaign with him to change this situation :) He is away until the end of
October though.

Updated
SPEC: http://jgu.fedorapeople.org/emacs-bbdb.spec
SRPM: http://jgu.fedorapeople.org/emacs-bbdb-2.35-7.fc7.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list