[Bug 283571] Review Request: homebank - Free easy personal accounting for all

bugzilla at redhat.com bugzilla at redhat.com
Sun Sep 9 18:51:11 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: homebank - Free easy personal accounting for all


https://bugzilla.redhat.com/show_bug.cgi?id=283571





------- Additional Comments From opensource at till.name  2007-09-09 14:51 EST -------
Using Categories the Application and X-Fedora in the .desktop is deprecated
according to:
https://bugzilla.redhat.com/show_bug.cgi?id=278481#c5


Here is also a German entry for the .desktop file:
Comment[de]=Persönliche Finanzverwaltung


You should use --dir ${RPM_BUILD_ROOT}%{_datadir}/applications in the
desktop-file-install invocation, i.e. use either ${RPM_BUILD_ROOT} or
%{buildroot} in you spec.

use
--vendor="fedora" instead of "%{_vendor}", on my local F7 machine %{_vendor}
expands to redhat, not fedora.


The install invocations for source1 and 2 should be done with "-p" to preserve
timestamps.


You need to add GTK icon cache scriptlets, see:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda
And also the mime cache scriptlets, see (on the same page):
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-5f93ed83c968bb73b052c06ba0d7139e28f35d93


I guess this will lead to a orphaned directory:
%{_datadir}/%{name}/*
Better use
%{_datadir}/%{name}/
to include the directory itself.


This is good: :-)
Tarball is identical with upstream:
$ md5sum homebank-3.5.tar.gz*
4120d19081f3f67f3723cca8f847278b  homebank-3.5.tar.gz
4120d19081f3f67f3723cca8f847278b  homebank-3.5.tar.gz.orig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list