[Bug 252124] Review Request: filezilla - FileZilla FTP, FTPS and SFTP client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: filezilla - FileZilla FTP, FTPS and SFTP client


https://bugzilla.redhat.com/show_bug.cgi?id=252124


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-09-10 01:58 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
9751433785d98e069f4c404c2d3d3231  FileZilla_3.0.0_src.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ update-desktop-database scriptlets are used.
+ Desktop file handled correctly.
+ filezilla-3.0.0-1.fc8 package ->
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0)
libgcc_s.so.1(GLIBC_2.0) libgnutls.so.13 libgnutls.so.13(GNUTLS_1_3)
libidn.so.11 libm.so.6 libm.so.6(GLIBC_2.1) libpthread.so.0
libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.2) libstdc++.so.6
libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libwx_baseu-2.8.so.0
libwx_baseu-2.8.so.0(WXU_2.8) libwx_baseu_net-2.8.so.0
libwx_baseu_net-2.8.so.0(WXU_2.8) libwx_baseu_xml-2.8.so.0
libwx_gtk2u_adv-2.8.so.0 libwx_gtk2u_adv-2.8.so.0(WXU_2.8)
libwx_gtk2u_aui-2.8.so.0 libwx_gtk2u_aui-2.8.so.0(WXU_2.8)
libwx_gtk2u_core-2.8.so.0 libwx_gtk2u_core-2.8.so.0(WXU_2.8)
libwx_gtk2u_html-2.8.so.0 libwx_gtk2u_qa-2.8.so.0 libwx_gtk2u_xrc-2.8.so.0
libwx_gtk2u_xrc-2.8.so.0(WXU_2.8) rtld(GNU_HASH)
+ GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.