[Bug 280751] Review Request: qmmp - Qt-based multimedia player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qmmp - Qt-based multimedia player


https://bugzilla.redhat.com/show_bug.cgi?id=280751





------- Additional Comments From kvolny at redhat.com  2007-09-12 07:30 EST -------
(In reply to comment #4)
> * missing "BuildRequires: cmake"

oops, originally I used qmake and I forgot to add cmake later ...
- fixed

> * not building with $RPM_OPT_FLAGS / %{optflags}
>   (run  make VERBOSE=1  to see)

- it should be fixed by using %cmake macro (?)

> * licence seems to be GPLv2+
>   source files contain the "or any later version" phrase)

you are right; I was confused by some web and did not look into the sources
- fixed

> * build failed here due to SMP make flags:

I use -j3 (dualcore Xeon) and it works_for_me(tm) - do you have any idea why 
the error happens? I am not a programmer, it would take me ages to figure it 
out (especially when I cannot reproduce) :-(

> * GPLv2 text is not included! (only compiled in)

- fixed (added COPYING to %doc)

> * shared libraries are not chmod +x

- fixed

> * rpmlint qmmp-0.1.4-2.fc8.i386.rpm
> qmmp.i386: E: invalid-soname /usr/lib/libqmmp.so libqmmp.so
>  => acceptable during development, but it requires strictly
>   versioned "Requires" in plugin packages

I guess this is upstream problem?
- should I rename the library somehow and make a symlink at the end 
of %install?

> * package provides SONAMEs it must not provide except
> for "libqmmp.so":

- fixed

new SRPM: http://sn.bluehost.cz/tmp/no-mp3/qmmp-0.1.4-3.fc7.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.