[Bug 284961] Review Request: serenity - KDE Style and Window Decoration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: serenity - KDE Style and Window Decoration


https://bugzilla.redhat.com/show_bug.cgi?id=284961





------- Additional Comments From thomas.moschny at gmx.de  2007-09-12 18:39 EST -------
Spec URL: http://thm.1erlei.de/serenity.spec (updated)
SRPM URL: http://thm.1erlei.de/serenity-1.7.1-2.fc7.src.rpm

(In reply to comment #1)
> If it is your second package, how did you submit your first package ?
> what is the name of your first package?

Sorry, this was misleading. The first package, python-textile, also needs to 
be reviewed, see #284101.

> I can sponsor you but first I would like to see whether you have understood 
> the fedora packaging guidelines. So please do at least 2 informal reviews of 
> any package of your choice by adding me as CC: to that bug.

Ok, will do that.

> #002: BuildRequires:  kdebase-devel >= 3.0
> Remove >= 3.0, as fedora core 6 and onwards already has a kde beyond 3.0

Fixed.

> #003: # FIXME: ldconfig needed?
> no it doesn't. use rpmlint to verify.

Removed.

(In reply to comment #2)
> #004: 
> 
BuildRoot:      %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
> Please refer to the fedora packaging guidelines and update the BuildRoot
> 

This seems to be a bit controversial, but 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
clearly recommends the above line for BuildRoot.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.