[Bug 225634] Merge Review: cadaver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: cadaver


https://bugzilla.redhat.com/show_bug.cgi?id=225634





------- Additional Comments From jorton at redhat.com  2007-09-13 02:34 EST -------
Thanks for the review!

> - Remove the zero epoch from the neon-devel BR

Fixed.

> - Include a quick comment as to why pie is needed

It's not "needed", it's a feature, I don't think that explaining what -pie is in
every spec file which uses it is really a good idea.

> - Change %defattr(-,root,root) to the more usual %defattr(-,root,root,-)
>   (pretty useless, though, since the package doesn't include directories)

Fixed.

> - Move the %doc line up so that it isn't in between two normal lines

And fixed.  In -2.  Also fixed the use of %makeinstall, which is now unnecessary
in 0.23.0.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.