[Bug 253024] Review Request: makehuman - Modeling of three-dimensional humanoid characters

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: makehuman - Modeling of three-dimensional humanoid characters


https://bugzilla.redhat.com/show_bug.cgi?id=253024





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-13 11:13 EST -------
First comment:

* update-desktop-database
  - Not needed because this desktop does not contain any mimetypes.

* rpmlint
  - Please explain what the folloiwng zero-length files are for.
-------------------------------------------------------------
/usr/share/makehuman/targets/ns_tongue/tongue_camaleon.target
/usr/share/makehuman/targets/ns_teeth/teeth_gengivite.target
/usr/share/makehuman/targets/l_ear2/l_ear_incisura_intertragica_down.target
/usr/share/makehuman/targets/ns_abdomen/abdomen_twist.target
--------------------------------------------------------------

* Timestamp
  - This package installs many "data" files and keeping timestamps
    on those files is _very_ desirable.
    * First add the option 'INSTALL="install -p"' to 'make install'
      for files under /usr/share/makehuman/base.* .
  - For the rest of the files, almost of them are installed by
    "cp -R", like:
---------------------------------------------------------------
make[2]: Entering directory `/builddir/build/BUILD/makehuman-0.9/data'
make[2]: Nothing to be done for `install-exec-am'.
/builddir/build/BUILD/makehuman-0.9/install-sh -d
/var/tmp/makehuman-0.9-1.fc8-root-mockbuild/usr/share/makehuman
cp -R ./targets /var/tmp/makehuman-0.9-1.fc8-root-mockbuild/usr/share/makehuman
cp -R ./rotations /var/tmp/makehuman-0.9-1.fc8-root-mockbuild/usr/share/makehuman
cp -R ./rib_data /var/tmp/makehuman-0.9-1.fc8-root-mockbuild/usr/share/makehuman
----------------------------------------------------------------
     So, changing "cp -R" to "cp -pR" will keep timestamps on
     almost all files. Please fix the corresponding Makefile(s).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.