[Bug 276961] Review Request: straw - Desktop news aggregator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: straw - Desktop news aggregator


https://bugzilla.redhat.com/show_bug.cgi?id=276961





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-14 09:55 EST -------
* disttag
  - Please consider to use %?dist tag.
    http://fedoraproject.org/wiki/Packaging/DistTag

* Redundant Requires/BuildRequires
  - Please remove redundant Requires/BuildRequires.
    For example, gnome-python2-gconf requires gnome-python2,
    so "Requires: gnome-python2" is not needed.

  - And why this package should have
    "Requires: pygtk2-devel" (not BuildRequires)?

* Conflicts
  - Please explain why you set "conflicts: python-adns".
    The valid cases of using "Conflicts" are in
    http://fedoraproject.org/wiki/Packaging/Conflicts

* GConf
  - GConf schemas files should still be under 
    %_sysconfdir/gconf/schemas, not under %_datadir
    (and don't mark as %config).

  - And please check GConf scriptlets again.
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
    * %pre, %post and %preun scriptlets are needed
    * [NAME] must be replaced with the actual gconf file's name.
    * Note: "killall -HUP gconfd-2 || :" is no longer needed.
      (see the last "Notes" in GConf scriptlet section).

* srpm indentation
  - rpmlint shows
-----------------------------------------------------
[tasaka1 at localhost straw]$ rpmlint straw-0.27-5.src.rpm
straw.src: W: mixed-use-of-spaces-and-tabs (spaces: line 82, tab: line 5)

[tasaka1 at localhost straw]$ rpmlint -I mixed-use-of-spaces-and-tabs
mixed-use-of-spaces-and-tabs :
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.
-----------------------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.