[Bug 242310] Review Request: moreutils - Additional unix utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: moreutils - Additional unix utilities


https://bugzilla.redhat.com/show_bug.cgi?id=242310


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |
         AssignedTo|nobody at fedoraproject.org    |j.w.r.degoede at hhs.nl
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From j.w.r.degoede at hhs.nl  2007-09-17 16:54 EST -------
Hi Marc,

As discussed by private mail, I'll review your 3 submissions and when they are
all approved I'll sponsor you.

I've done a full review of the latest version and I've found a few issues
besides the potential name clash for ts:

Must FIX:
---------
* change license from "GPL" to "GPLv2" (sponge is GPL version 2 only)
* upstream has 0.24 out, update please
* The weird CPAN comment doesn't make any sense, either remove it or make it 
  make sense
* Please use the BuildRoot from the Packaging Guidelines
* Don't install README and COPYING under %{_datadir}/%{name} instead add them to
  %files like this: "%doc README COPYING" rpm wil then automatically create a 
  dir under /usr/share/doc for them and put them there.
* Don't use %doc for man files.


As for the ts namespace clash, I see 2 options:
1) Ship with upstreams ts name, so that we are consistent with upstream, and 
   rename to ts-stdin if an actual file conflict arises
2) Rename to ts-stdin now

I tend to prefer 1, but if we do 2 now, we avoid pain for end users if we have
to rename later.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.