[Bug 229180] Review Request: texlive-texmf - Architecture independent parts of the TeX formatting system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: texlive-texmf - Architecture independent parts of the TeX formatting system


https://bugzilla.redhat.com/show_bug.cgi?id=229180





------- Additional Comments From pertusus at free.fr  2007-09-18 18:01 EST -------
(In reply to comment #51)
> (In reply to comment #42)
> > I propose the following additions to the texmf substitutions:
> > %{__sed} -i 's?^TEXMF =.*?TEXMF =
> >
>
{$TEXMFCONFIG,$TEXMFVAR,$TEXMFHOME,$TEXMFSYSCONFIG,!!$TEXMFSYSVAR,!!$TEXMFLOCAL,!!$TEXMFMAIN,!!$TEXMFDIST}?'
> > %{__sed} -i 's?^TEXMFLOCAL =.*?TEXMFLOCAL = %{_texmf_local}?'
> 
> Could you be more verbose on these substitutions?

The second one is rather logical. The default uses selfautoparent,
which is completely inconsistent with the remaining of the 
packaging.

For TEXMF, $TEXMFSYSCONFIG is better without !!, such that even
if the user doesn't run mktexlsr his config files are taken into 
account. Otherwise I have put !!$TEXMFLOCAL before our directories
such that the user additions are taken into account.


> > in the tkdefaults patch, the defaults should be like in texlive
> > and the appropriate Requires set.
> 
> I don't think so, the defaults there should match Fedora, so that it has to be
> tuned appropriatelly.

I wanted to say like in the texlive Fedora package (xdg-utils, 
htmlviewer...)

> > Instead of doing a link for the cmap ghostscript resources
> > I think that the texmf.cnf should be changed.
> 
> Please provide a patch for this.

Ok. What about:


 if [ -d "%{_datadir}/ghostscript/`gs --version| cut -d . -f 1-2`/Resource/CMap"
] ; then
  cmap_dir="%{_datadir}/ghostscript/"`gs --version| cut -d . -f
1-2`"/Resource/CMap/"
elif [ -d "%{_datadir}/ghostscript/Resource/CMap" ] ; then
  cmap_dir="%{_datadir}/ghostscript/Resource/CMap/"
fi
if [ z"$cmap_dir" != 'z' ]; then
  pushd texmf/web2c
  %{__sed} -i 's?^CMAPFONTS = .*?CMAPFONTS =
.;$TEXMF/fonts/cmap//;'"$cmap_dir"'?' texmf.cnf
  popd
fi

> > Also I think that 
> > # move the configuration files and symlink them
> > is wrong. Better leave as is.
> 
> I don't think so. Storing config files to /etc is perfectly fine IMO.

Once again config files under the packager/upstream control
should be in %{_datadir}/texmf..., those under the user control should
be in /etc/texmf...

In the case of texlive-texmf context.cnf fmtutil.cnf texmf.cnf updmap.cfg
should be under the packager/upstream control, but the user should 
be able to put his own files in /etc/texmf/web2c to augment/override
the package files.

And mktex.cnf should be in /etc/texmf/web2c under the user control,
with %config(noreplace).

> I decided to remove the common package as it's useless and moved bits from there
> to the main package.

Ok.
 

> > The scriptlet commands should be in Requires(...). I hope
> > that rpm can figure out that the binary package has in fact to
> > be installed before the texmf package to be able to run the 
> > scriptlet.
> > 
> > Also it seems to me that at least updmap should be run as a 
> > texmf package scriptlet, and not as the main package scriptlet, 
> > since all that updmap needs is in the texmf packages, including
> > the config file.
> 
> Seems reasonable, please provide patch.

I will do later, I am still learning about those 
utilities/scriptlets and still trying to understand what/when to run
them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.