[Bug 226200] Merge Review: nkf

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: nkf


https://bugzilla.redhat.com/show_bug.cgi?id=226200


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora




------- Additional Comments From panemade at gmail.com  2007-09-20 04:50 EST -------
preliminary review ->
rpmlint complained
nkf.src:29: W: rpm-buildroot-usage %prep %{__rm} -rf    $RPM_BUILD_ROOT
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

nkf.src:30: W: rpm-buildroot-usage %prep %{__mkdir_p}   $RPM_BUILD_ROOT/%{_bindir}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

nkf.src:31: W: rpm-buildroot-usage %prep %{__mkdir_p}  
$RPM_BUILD_ROOT%{_mandir}/{man1,ja/man1}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

nkf.src:39: W: rpm-buildroot-usage %build CFLAGS="$RPM_OPT_FLAGS" perl
Makefile.PL PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

===> Remove %prep section lines add them to %build

nkf.src: W: summary-ended-with-dot A Kanji code conversion filter.
Summary ends with a dot.

perl-NKF.i386: W: hidden-file-or-dir
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/NKF/.packlist
The file or directory is hidden. You should see if this is normal,
and delete it from the package if not.

perl-NKF.i386: W: perl-temp-file
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/NKF/.packlist
You have a perl temporary file in your package. Usually, this
file is beginning with a dot (.) and contain "perl" in its name.

perl-NKF.i386: E: non-standard-executable-perm
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/NKF/NKF.so 0555
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

nkf.src: W: no-url-tag
The URL tag is missing.


SHOULD:
  Add missing BR perl-ExtUtils-MakeMaker
  Preserve timestamps
  clean buildroot in install stage


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.