[Bug 290041] Review Request: generic-logos - Icons and pictures

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: generic-logos - Icons and pictures


https://bugzilla.redhat.com/show_bug.cgi?id=290041





------- Additional Comments From kevin at tummy.com  2007-09-20 22:57 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv2)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
See below - Package owns all the directories it creates.  
See below - No rpmlint output.
See below - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag

Issues:

1. Should the
# should be ifarch i386
bits really be %ifarch? why aren't they now...

2. I assume cvs is the Source for this package?
Perhaps it would be worth making a hosted project in case people want to
work on/contribute to this package?

3. rpmlint says:

generic-logos.noarch: W: no-url-tag
generic-logos.src: W: no-url-tag

A hosted (or other upstream) would fix this.

generic-logos.noarch: E: only-non-binary-in-usr-lib

Ignore since it has to put anaconda-runtime has to be there.

generic-logos.src:10: W: unversioned-explicit-obsoletes redhat-logos

Can you specifiy a version on that Obsoletes?

generic-logos.src:70: E: hardcoded-library-path in /usr/lib/anaconda-runtime/*.jpg

No way to avoid that I see off hand. Do you?

generic-logos.src: W: strange-permission generic-logos.spec 0600

Spec should be 644.

4. Should this package Require the anaconda, grub, and other packages
where it places images in dirs they own? Or should this be an exception
to that rule?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.