[Bug 226200] Merge Review: nkf

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: nkf


https://bugzilla.redhat.com/show_bug.cgi?id=226200





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-21 01:56 EST -------
Sorry, but please wait.

* Compilation does not honor %optflags
  http://koji.fedoraproject.org/koji/getfile?taskID=168881&name=build.log
------------------------------------------------------
+ make nkf
cc -O -c utf8tbl.c
cc -O -o nkf nkf.c utf8tbl.o
------------------------------------------------------

* perl macro
  - Please use %perl_vendorarch or %perl_vendorlib

* Timestamp
  - For SOURCE3, please use "cp -p" to keep timestamp.

* defattr
  - Now we recommend %defattr(-,root,root,-)

* Using direct command vs using macro command
  - Please choose if you use write commands directly, or
    use macros as much as possible.

    For example, if you want to use %__install_p, you also
    want to use %__rm, %__cp, %__make, %__chmod.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.