[Bug 282521] Review Request: dblatex - DocBook to LaTeX/ConTeXt Publishing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dblatex - DocBook to LaTeX/ConTeXt Publishing


https://bugzilla.redhat.com/show_bug.cgi?id=282521





------- Additional Comments From pertusus at free.fr  2007-09-21 07:46 EST -------
The conflict with tetex-tex4ht should be fixed in devel. For 
previous versions I don't want to make changes, you should add a 
conflict.



The package installs passivetex and some sty, this shouldn't be:

/usr/share/dblatex/latex/misc/attachfile.sty
/usr/share/dblatex/latex/misc/bibtopic.sty
/usr/share/dblatex/latex/misc/enumitem.sty
/usr/share/dblatex/latex/misc/multirow2.sty
/usr/share/dblatex/latex/misc/passivetex
/usr/share/dblatex/latex/misc/passivetex/LICENSE
/usr/share/dblatex/latex/misc/passivetex/dummyels.sty
/usr/share/dblatex/latex/misc/passivetex/unicode.sty
/usr/share/dblatex/latex/misc/ragged2e.sty

attachfile.sty is not in tetex, and therefore should be packaged.
Maybe it is in texlive, in that case, it could be acceptable
to ship the one in dblatex (but in texmf) waiting for this style 
file to enter fedora through texlive.

In my spec I did:
# these are already in tetex-latex:
for file in bibtopic.sty enumitem.sty ragged2e.sty passivetex/; do
  rm -rf $RPM_BUILD_ROOT%{_datadir}/dblatex/latex/misc/$file
done


The tex files (especially the .sty) should be below 
/usr/share/texmf instead of in /usr/share/dblatex/.

The xsl stylesheets should also be in xsl stylesheet directories.
I used
%{_datadir}/sgml/docbook/xsl-stylesheets/dblatex/
It is not that obvious since it seems that dblatex uses xsl files
for other purposes than xsltproc call, to retrieve the version.
However in the debian package the xsl files are in xsl directory
and I can't see any obvious patching.

It would be better not to use the included which, but system 
python-which. In my srpm there is a very simple patch to use system
which instead of the one from contrib.

You can apply the debian patch it only creates things below a debian
directory, but I haven't found many interesting things in.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.