[Bug 287801] Review Request: Sirius - Othello game for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Sirius - Othello game for GNOME
Alias: sirius

https://bugzilla.redhat.com/show_bug.cgi?id=287801


makghosh at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |sirius




------- Additional Comments From makghosh at gmail.com  2007-09-21 15:31 EST -------
Issues Resolved:

* perl modules BuildRequires fixed to perl(XML::Parser)

* License tag updated to GPLv2+

* CFLAGS option removed from make. So its' now:
-----------------------------------------------
%build
%configure
make %{?_smp_mflags} 
-----------------------------------------------

* INSTALL option added to make install. Its' now:
-----------------------------------------------
make install DESTDIR=%{buildroot} INSTALL="%{__install} -p"
-----------------------------------------------

* UTF-8 encoding of "AUTHORS", "Changelog", "README":
  - These three files were in ISO-8859 encoding. So i used the following
commands to change them to UTF-8 encoding:
-----------------------------------------------
[Joy at localhost sirius-0.8.0]$ iconv -f ISO-8859-1 -t UTF-8 AUTHORS
[Joy at localhost sirius-0.8.0]$ iconv -f ISO-8859-1 -t UTF-8 Changelog
[Joy at localhost sirius-0.8.0]$ iconv -f ISO-8859-1 -t UTF-8 README
-----------------------------------------------
  - So now the encoding of these files :
-----------------------------------------------
[Joy at localhost sirius-0.8.0]$ file AUTHORS ChangeLog README 
AUTHORS:   UTF-8 Unicode text
ChangeLog: UTF-8 Unicode English text
README:    UTF-8 Unicode text
-----------------------------------------------
  - The output of rpmlint is given as follows for i386 rpm:
-----------------------------------------------
[Joy at localhost redhat]$ rpmlint -i RPMS/i386/sirius-0.8.0-8.fc7.i386.rpm 
[Joy at localhost redhat]$
-----------------------------------------------

Issues that still needs work:

* Will try to fix the sirius-0.8.0-autoreconf.patch.bz2 problem. Seeing the ways
 to fix this. By the way, when I tried to do a rpmbuild by commenting out %patch
part in the %prep section, it returned with following errors:
-----------------------------------------------
<more lines above>
+ /usr/lib/rpm/redhat/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump
+ /usr/lib/rpm/brp-python-bytecompile
+ /usr/lib/rpm/redhat/brp-java-repack-jars
error: Bad file: /usr/src/redhat/SOURCES/sirius-0.8.0-autoreconf.patch.bz2: No
such file or directory


RPM build errors:
    Bad file: /usr/src/redhat/SOURCES/sirius-0.8.0-autoreconf.patch.bz2: No such
file or directory
-----------------------------------------------

* Also trying to fix: "warning: integer constant is too large for 'long' type"

* desktop-category: I think there's no such category in spec file. If I
seriously misunderstood you for this, please clarify.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.