[Bug 244031] Review Request: qfits - A stand-alone general purpose FITS library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qfits - A stand-alone general purpose FITS library


https://bugzilla.redhat.com/show_bug.cgi?id=244031





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-22 03:10 EST -------
(In reply to comment #9)
* Naming

> I think you mean: 
> qfits -> qfits-lib 
> qfits-tools -> qfits
> Is that correct? 
  - Yes, however
  * Many packagers seem to choose -libs, not -lib: so IMO
     qfits-libs
     qfits
     qfits-devel (not qfits-libs-devel)
    is better
   * Also, qfits should have "qfits-libs = %{version}-%{release}"
     (and qfits-devel should have
      "qfits-libs = %{version}-%{release}")

* Group
  - IMO it is better that the Group of qfits-libs is
    "System Environment/Libraries".

* %check
  - As source code has test/ subdirectory and "make check"
    can be executed, please add %check stage and do
    "make check".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.