[Bug 292691] Review Request: fbreader - E-book reader

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fbreader - E-book reader


https://bugzilla.redhat.com/show_bug.cgi?id=292691





------- Additional Comments From panemade at gmail.com  2007-09-22 06:17 EST -------
(In reply to comment #4)
> Spec URL: http://hircus.org/fedora/fbreader/fbreader.spec
> SRPM URL: http://hircus.org/fedora/fbreader/fbreader-0.8.6d-2.fc8.src.rpm
> 
> I thought about doing something like what chestnut does, but the annoying thing
> is that you have to do some rather manual surgeries on the desktop files --
> desktop-file-install does not let you change the content of fields, so in
> chestnut's case, if you install both the Qt and GTK GUI packages, both have the
> same Name and Comment fields. Would be confusing..
> 
> I think I'll stick to using GTK for now, and people who want the Qt interface
> can rebuild the SRPM themselves.
> 
> Removed the vendor tag, since a lot of apps don't use it anymore (e.g.
> rhythmbox). the Guidelines make it seem more mandatory than it actually is.
> 
 But good to follow what current guidelines said. So you should add vendor tag.

> I think that covered everything -- could you review the updated spec? Thanks!



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.