[Bug 245357] Review Request: libopensync-plugin-syncml - plugin for using syncml with opensync

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libopensync-plugin-syncml - plugin for using syncml with opensync


https://bugzilla.redhat.com/show_bug.cgi?id=245357


michel.sylvan at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michel.sylvan at gmail.com




------- Additional Comments From michel.sylvan at gmail.com  2007-09-22 13:02 EST -------
I can't sponsor (have you e-mailed fedora-devel or ask on the IRC channel?), but
here's a quick review:

- License field is wrong. It is LGPL version 2.1 or above, which using the old
guideline would have been LGPL, and the new license guideline requires you to
state it as LGPLv2+

- Syncml should be capitalized properly: SyncML
- In %changelog, don't insert a linebreak between your contact detail and the
version-release info. Also, avoid smiley and capitalize your name properly?
- Description should not just copy %{summary}

Package builds fine in mock for F-7

Looks good otherwise

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.