[Bug 294341] Review Request: open-vm-tools-kmods - Kernel modules for open-vm-tools

bugzilla at redhat.com bugzilla at redhat.com
Sun Sep 23 09:43:10 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: open-vm-tools-kmods - Kernel modules for open-vm-tools


https://bugzilla.redhat.com/show_bug.cgi?id=294341





------- Additional Comments From denis at poolshark.org  2007-09-23 05:43 EST -------
(in reply to comment #17)
> > some of the drivers will require a lot
> > of changes or a complete rewrite to get accepted (and vmblock probably
> > wouldn't get accepted at all and we'd need to rewrite it using fuse).
>
> So it's not actually something we'd have wanted to ship even if we _hadn't_
> decided not to allow any more kernel module packages.
> 
> The reason we decided not to allow any more kernel module packages is because
> this is actually almost always the case. If it's not good enough for upstream,
> it's not good enough for us. There are _few_ exceptions, and we've _always_
> coped with those by carrying patches in the kernel package.

David, I think that is not a fair assessment. Pushing code to the upstream
kernel is known to be a long and arduous process, and is not always related to
the quality of the code in question, but more about the way it's written, how
it's integrated with other/newer parts of the kernel, and so on.

A prime example I'm familiar with was the Marvell SATA driver: a very high
quality (based on extensive experience) driver, but written straight on top of
the SCSI stuff without using the new libata layer, and as such unpushable
upstream. (a moot example too, Marvell is now working with the upstream
maintainer to port the driver, but these things take time)

I think the things that matter most here are:
 1) is the code stable and high-quality (and well QAed) ?
 2) is the code actively maintained ?
 3) will the code have a large user base ?



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list