[Bug 225733] Merge Review: eruby
bugzilla at redhat.com
bugzilla at redhat.com
Wed Sep 26 05:46:07 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: eruby
https://bugzilla.redhat.com/show_bug.cgi?id=225733
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade at gmail.com 2007-09-26 01:46 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM but not for RPM.
eruby-devel.i386: W: no-dependency-on eruby
+ source files match upstream.
af294fe34dc6cf24228aec95167b3099 eruby-1.0.5.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
- dist tag is NOT present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ -devel and -libs subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ldconfig scriptlets are used.
+ Package eruby-1.0.5-10 ->
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libcrypt.so.1 libdl.so.2 liberuby.so.1.0 libm.so.6
libpthread.so.0 libruby.so.1.8 rtld(GNU_HASH)
+ Package eruby-libs-1.0.5-10 ->
Provides: eruby.so liberuby.so.1.0 ruby(eruby) = 1.0.5
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libcrypt.so.1 libdl.so.2
liberuby.so.1.0 libm.so.6 libpthread.so.0 libruby.so.1.8 rtld(GNU_HASH)
ruby(abi) = 1.8
+ Package eruby-devel-1.0.5-10 ->
Requires: liberuby.so.1.0 ruby(eruby) = 1.0.5
+ Not a GUI app.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list