[Bug 248617] Review Request: cdcollect - Simple CD/DVD catalog for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cdcollect - Simple CD/DVD catalog for GNOME


https://bugzilla.redhat.com/show_bug.cgi?id=248617


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-09-26 07:11 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM
- rpmlint complains for RPM as
  cdcollect.i386: E: no-binary
  cdcollect.i386: E: only-non-binary-in-usr-lib
   But these can be ignored for mono packages.
+ source files match upstream.
33f71604b9dfb84497b4bc2fce69e89b  cdcollect-0.6.0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ GConf scriptlets are used.
+ Desktop file handled correctly.
+ Package cdcollect-0.6.0-3.fc8 ->
  Provides: config(cdcollect) = 0.6.0-3.fc8 mono(cdcollect) = 0.2.2825.11093
  Requires: /bin/sh config(cdcollect) = 0.6.0-3.fc8 gnome-sharp gtk-sharp2 >=
2.8.0 mono-core >= 1.1.17 mono-data-sqlite sqlite >= 3.3.5
+ GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.