[Bug 306431] Review Request: scim-python - a python wrapper for SCIM input platform

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scim-python - a python wrapper for SCIM input platform


https://bugzilla.redhat.com/show_bug.cgi?id=306431


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-09-27 08:07 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM but not for RPM.
scim-python.i386: W: symlink-should-be-relative
/usr/lib/scim-1.0/1.4.0/IMEngine/scim-python-engine.so
/usr/lib/python2.5/site-packages/scim.so
Absolute symlinks are problematic eg. when working with chroot environments.

scim-python.i386: W: symlink-should-be-relative
/usr/lib/scim-1.0/1.4.0/SetupUI/scim-python-setup.so
/usr/lib/python2.5/site-packages/scim.so
Absolute symlinks are problematic eg. when working with chroot environments.
  I think this should not be blocker as absolute path looks correct for Fedora.
+ source files match upstream.
70acce6fc5e343cc0644c81f2092b9a1  scim-python-0.1.3.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Package scim-python-0.1.3-1.fc8 ->
  Provides: scim.so scim.so(SCIM_0.1)
  Requires: libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.4) libcairo.so.2
libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0
libgtk-x11-2.0.so.0 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0
libpthread.so.0 libpython2.5.so.1.0 libscim-1.0.so.8
libscim-1.0.so.8(LIBSCIM_1.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(GLIBCXX_3.4) libutil.so.1 pygtk2 python(abi) = 2.5 python-enchant
rtld(GNU_HASH) scim
+ Not a GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.