[Bug 226462] Merge Review: system-config-lvm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-lvm


https://bugzilla.redhat.com/show_bug.cgi?id=226462


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2007-09-28 11:24 EST -------
need some SPEC cleanups
1)  avoid makeinstall usage
http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002
2) update buildroot tag as said below
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
3) use make %{?_smp_mflags}

rpmlint said 
system-config-lvm.src: W: mixed-use-of-spaces-and-tabs (spaces: line 100, tab:
line 35)
system-config-lvm.src: W: summary-ended-with-dot A utility for graphically
configuring Logical Volumes.
system-config-lvm.src: W: invalid-license GPL
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/fdisk_wrapper.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/VolumeGroup.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/pixmaps/VG.xpm 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/pixmaps/PV.xpm 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/pixmaps/UV.xpm 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/Segment.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/Partition.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/ExtentBlock.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/execute.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/renderer.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/utilities.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/Cluster.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/BlockDevice.py 0640
system-config-lvm.noarch: W: no-dependency-on usermode
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/lvmui_constants.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/lvm_model.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/parted_wrapper.py 0640
system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/Volume.py
0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/Filesystem.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/cylinder_items.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/PhysicalVolume.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/pixmaps/grad3.xpm 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/pixmaps/LV.xpm 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/CommandHandler.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/CommandError.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/Volume_Tab_View.py 0640
system-config-lvm.noarch: E: non-executable-script
/usr/share/system-config-lvm/Volume_Tab_View.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/Properties_Renderer.py 0640
system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/Fstab.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/InputController.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/WaitMsg.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/LogicalVolume.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/BlockDeviceModel.py 0640
system-config-lvm.noarch: E: non-readable
/usr/share/system-config-lvm/Multipath.py 0640
system-config-lvm.noarch: W: summary-ended-with-dot A utility for graphically
configuring Logical Volumes.
system-config-lvm.noarch: W: invalid-license GPL
system-config-lvm.noarch: W: conffile-without-noreplace-flag
/etc/pam.d/system-config-lvm
system-config-lvm.noarch: W: conffile-without-noreplace-flag
/etc/security/console.apps/system-config-lvm

Update package. Better to provide new SPEC and SRPM links for this package
before actually committing in CVS.




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.