[Bug 226464] Merge Review: system-config-network

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-network


https://bugzilla.redhat.com/show_bug.cgi?id=226464


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2007-09-28 11:37 EST -------
Need some SPEC cleanups as rpmlint gave me 
system-config-network.src:11: W: unversioned-explicit-obsoletes isdn-config
system-config-network.src:11: W: unversioned-explicit-obsoletes internet-config
system-config-network.src:11: W: unversioned-explicit-obsoletes rp3
system-config-network.src:11: W: unversioned-explicit-obsoletes
redhat-config-network
system-config-network.src:25: W: unversioned-explicit-obsoletes netcfg
system-config-network.src:25: W: unversioned-explicit-obsoletes
redhat-config-network-tui
system-config-network.src:25: W: unversioned-explicit-obsoletes netconfig
==>  The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing.  This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
possible.

system-config-network.src:26: W: unversioned-explicit-provides
redhat-config-network-tui

==>The specfile contains an unversioned Provides: token, which will match all
older, equal, and newer versions of the provided thing.  This may cause
update problems and will make versioned dependencies, obsoletions and conflicts
on the provided thing useless -- make the Provides versioned if possible.


system-config-network.src: W: invalid-license GPL
system-config-network.noarch: W: no-documentation
system-config-network.noarch: W: no-dependency-on usermode
system-config-network.noarch: E: explicit-lib-dependency libglade2
==> You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

system-config-network.noarch: W: invalid-license GPL
system-config-network.noarch: W: obsolete-not-provided isdn-config
system-config-network.noarch: W: obsolete-not-provided internet-config
system-config-network.noarch: W: obsolete-not-provided rp3
system-config-network-tui.noarch: W: no-documentation
system-config-network-tui.noarch: E: non-executable-script
/usr/share/system-config-network/netconfpkg/exception.py 0644
system-config-network-tui.noarch: W: invalid-license GPL
==> Update Licenst tag

system-config-network-tui.noarch: W: obsolete-not-provided netcfg
system-config-network-tui.noarch: W: obsolete-not-provided netconfig
==> If a package is obsoleted by a compatible replacement, the obsoleted package
must also be provided in order to provide clean upgrade paths and not cause
unnecessary dependency breakage.  If the obsoleting package is not a compatible
replacement for the old one, leave out the provides.

Also,
  Good to use %defattr(-,root,root,-)


Update package. Better to provide new SPEC and SRPM links for this package
before actually committing in CVS.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.