[Bug 226467] Merge Review: system-config-rootpassword

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-rootpassword


https://bugzilla.redhat.com/show_bug.cgi?id=226467


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2007-09-28 12:53 EST -------
Preliminary Review:-

rpmlint on SRPM and RPM gave me
-------------------------------------
system-config-rootpassword.src:12: W: unversioned-explicit-obsoletes
redhat-config-rootpassword
==> The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing.  This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
possible.

system-config-rootpassword.src:21: W: prereq-use gtk2 >= 2.6
==> The use of PreReq is deprecated. In the majority of cases, a plain Requires
is enough and the right thing to do. Sometimes Requires(pre), Requires(post),
Requires(preun) and/or Requires(postun) can also be used instead of PreReq.

system-config-rootpassword.src: E: no-cleaning-of-buildroot %install
==> You should clean $RPM_BUILD_ROOT in the %clean section and just after the
beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT".

system-config-rootpassword.src: W: mixed-use-of-spaces-and-tabs (spaces: line
36, tab: line 39)
==> The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

system-config-rootpassword.noarch: W: no-documentation
system-config-rootpassword.noarch: E: script-without-shebang
/usr/share/system-config-rootpassword/rootpassword_tui.py
system-config-rootpassword.noarch: E: script-without-shebang
/usr/share/system-config-rootpassword/passwordDialog.py
==>This text file has executable bits set or is located in a path dedicated
for executables, but lacks a shebang and cannot thus be executed.  If the file
is meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.


system-config-rootpassword.noarch: W: symlink-should-be-relative
/usr/share/firstboot/modules/rootpassword.py
/usr/share/system-config-rootpassword/passwordDialog.py
==>Absolute symlinks are problematic eg. when working with chroot environments.

system-config-rootpassword.noarch: W: obsolete-not-provided
redhat-config-rootpassword
==> If a package is obsoleted by a compatible replacement, the obsoleted package
must also be provided in order to provide clean upgrade paths and not cause
unnecessary dependency breakage.  If the obsoleting package is not a compatible
replacement for the old one, leave out the provides.


system-config-rootpassword.noarch: W: conffile-without-noreplace-flag
/etc/pam.d/system-config-rootpassword
system-config-rootpassword.noarch: W: conffile-without-noreplace-flag
/etc/security/console.apps/system-config-rootpassword
==> A configuration file is stored in your package without the noreplace flag.
A way to resolve this is to put the following in your SPEC file:

%config(noreplace) /etc/your_config_file_here

----------------------------------------------------


also,
  1) update buildroot tag as given in
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
  2) packaging guidelines suggests use of make as 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e
  3) missing buildroot cleanup in %install. check
http://fedoraproject.org/wiki/Packaging/Guidelines#head-6c809b2e945ca78ae25d040f250be60f73181ef0
  4) any reason for not using macros for following line om %files section
   /usr/bin/system-config-rootpassword
   %dir /usr/share/system-config-rootpassword
   %dir /usr/share/system-config-rootpassword/pixmaps
   /usr/share/system-config-rootpassword/*
   %dir /usr/share/firstboot/
   %dir /usr/share/firstboot/modules
   /usr/share/firstboot/modules/rootpassword.py*

  5) Any reason for commenting %doc COPYING?
  6) good to use %defattr(-,root,root,-)

Update package. Better to provide new SPEC and SRPM links for this package
before actually committing in CVS.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.