[Bug 241079] Review Request: R-DynDoc-1.14.0 - Functions for dynamic documents
bugzilla at redhat.com
bugzilla at redhat.com
Sat Sep 29 20:57:15 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: R-DynDoc-1.14.0 - Functions for dynamic documents
https://bugzilla.redhat.com/show_bug.cgi?id=241079
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs at math.uh.edu 2007-09-29 16:57 EST -------
Looks good to me and follows the R packaging guidelines closely.
rpmlint is silent except for the expected one-line-command-in-* complaints.
* source files match upstream:
0e95de3c2ea047e7c46655bf2c4751895ede720b179195cff0831d12146a71ba
DynDoc_1.14.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
R-DynDoc = 1.14.0-5.fc8
=
/bin/sh
R
* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (R package registration)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list