[Bug 253549] Review Request: TzClock - GTK+ Time Zone Clock

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TzClock - GTK+ Time Zone Clock


https://bugzilla.redhat.com/show_bug.cgi?id=253549





------- Additional Comments From rc040203 at freenet.de  2007-09-30 12:04 EST -------
(In reply to comment #11)
> (In reply to comment #9)

> (In reply to comment #10)
> > (In reply to comment #9)
> > > the proper CFLAGS aren't getting passed to the compiler,
> > 
> > This applies here. The Makefile.am is broken. It doesn't apply *_CFLAGS
correctly.
> > 
>
> It seems that fedora compilation flags are correctly honored
> http://koji.fedoraproject.org/koji/getfile?taskID=178885&name=build.log
Not for me.

This Makefile.am is broken.

It uses
*_CFLAGS = -DXXX
this overrides automake's internal CFLAGS and violates automake working-principles.

Correct usage would be:
*_CFLAGS = $(AM_CFLAGS) <more-flags>

Further abuse: -DXXX are CPPFLAGS.
They do not belong into CFLAGS, they'd belong into *_CPPFLAGS

For detail consult the fine manual (info Automake).



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.