[Bug 439941] Review Request: javasqlite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: javasqlite


https://bugzilla.redhat.com/show_bug.cgi?id=439941


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |ville.skytta at iki.fi
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From ville.skytta at iki.fi  2008-04-01 11:19 EST -------
Excellent, I was about to submit this but you beat me to it.  Here's the first
pass of the review.

Many of the following have rationales at
http://fedoraproject.org/wiki/PackagingDrafts/Java, and my locale package at
http://cachalot.mine.nu/8/SRPMS/javasqlite-20080315-1.fc8.src.rpm should have
fixes for most of them.

- Group: Libraries: please change to Development/Libraries or System/Libraries

- BuildRequires: sqlite-devel missing

- Javadocs not built nor packaged

- Requires JNI lib -> jar can't be installed in /usr/share/java, install both to
%{_libdir}/%{name} instead (see eg. jnipath patch in my package)

- Documentation missing, %doc ChangeLog license.terms

- Test suite not run during build

- Should probably use specific -source argument to javac (eg. -source 5.0)
(mostly for gcj)

- Dependency on jre (versioned) missing

- I think the versioned jar filenames are pretty much pointless (see recent
discussion on fedora-devel and fedora-packaging)

- GCJ stuff not needed?

- $RPM_OPT_FLAGS not honored (see my cflags patch)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.