[Bug 440676] Review Request: lua-filesystem - File System Library for Lua

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lua-filesystem - File System Library for Lua


https://bugzilla.redhat.com/show_bug.cgi?id=440676


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2008-04-04 18:43 EST -------
Builds fine and rpmlint is silent.

The compiler is not called with the proper flags.  This leads to a broken
debuginfo package, among other issues.  It looks like you'll need to patch the
"config" file as it overwrites the passed CFLAGS.

* source files match upstream:
   226db0b2903e2a04de0ad0a71e53a0f629683a61172c228a3e7d416c226101ca  
   luafilesystem-1.4.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
X compiler flags are not correct.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
X debuginfo package is not complete.
* rpmlint is silent.
* final provides and requires are sane:
   lfs.so()(64bit)
   lua-filesystem = 1.4.0-1.fc9
  =
   lua >= 5.1
* %check is not present; no test suite upstream.  I do not know how to test this 
  software.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.