[Bug 440677] Review Request: lua-posix - A POSIX library for Lua

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lua-posix - A POSIX library for Lua


https://bugzilla.redhat.com/show_bug.cgi?id=440677


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2008-04-04 19:34 EST -------
This package has the same issue with compiler flags and incomplete debuginfo
package.  You can test the debuginfo package by doing a koji scratch build and
looking at the file list; if it doesn't include any source code then something
has gone off.  Another good test is to look through the build log and grep for
lines with cc or gcc that don't contain "FORTIFY_SOURCE".

There's a test script included, but I don't know quite enough about lua to tell
how you would run it or if its possible to run it at build time.  It would be
good to run it if possible.

* source files match upstream:
   f38a5b838495952bae8bd99fde2ac14a21c12947b426f26366a9299766419952  
   luaposix-5.1.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* no license text to include (public domain).
* latest version is being packaged.
* BuildRequires are proper.
X compiler flags are not correct.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
X debuginfo package is incomplete.
* rpmlint is silent.
* final provides and requires are sane:
   lua-posix = 5.1.2-1.fc9
  =
   lua >= 5.1
? %check is not present, but there's some sort of test suite included.  I don't 
  know how to run it, however.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.