[Bug 440999] Review Request: php-pear-File-Find - Class which facilitates the search of filesystems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-File-Find - Class which facilitates the search of filesystems


https://bugzilla.redhat.com/show_bug.cgi?id=440999


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-04-04 21:04 EST -------
I like how the code says that the LICENSE file is in the tarball when it's not.

Thanks for commenting on the issues surrounding the test suite.  Everything
looks good to me.

* source files match upstream:
   662dc82e1efe327bca3a18f585b1fbd8207f2c88da3b06492be14ec8c3aa4e8d  
   File_Find-1.3.0.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK (can't check the French versions)
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-pear-File-Find = 1.3.0-1.fc9
  =
   /bin/sh
   /usr/bin/pear

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module registration)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.