[Bug 438805] Review Request: php-pear-MDB2-Driver-pgsql - PostgreSQL driver for MDB2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2-Driver-pgsql - PostgreSQL driver for MDB2


https://bugzilla.redhat.com/show_bug.cgi?id=438805


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-04-04 23:01 EST -------
Builds fine; rpmlint says:
  php-pear-MDB2-Driver-pgsql.noarch: W: no-documentation
which is indeed the case; there's no documentation in the tarball.

* source files match upstream:
   7a051e90c63897701a93c9d3b02d79e6c696240c552694cf34cbc7eab6284691  
   MDB2_Driver_pgsql-1.4.1.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   php-pear(MDB2_Driver_pgsql) = 1.4.1
   php-pear-MDB2-Driver-pgsql = 1.4.1-1.fc9
  =
   /bin/sh
   /usr/bin/pear
   php-pear(MDB2) >= 2.4.1
   php-pear(PEAR) >= 1.4.0b1

* %check is not present.  There seem to be some tests in the package, but they 
   would require a configured postgres server and it's not generally possible to 
   run PHP tests at build time.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module registration).
* code, not content.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.