[Bug 438982] Review Request: pyfits - Python interface to FITS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyfits  - Python interface to FITS


https://bugzilla.redhat.com/show_bug.cgi?id=438982


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2008-04-05 00:27 EST -------
Builds OK; rpmlint says:
  pyfits.src:26: W: setup-not-quiet
Not a big deal; you can fix it by using "%setup -q".

  pyfits.noarch: E: non-executable-script 
   /usr/lib/python2.5/site-packages/pyfits/NP_pyfits.py 0644
  pyfits.noarch: E: non-executable-script 
   /usr/lib/python2.5/site-packages/pyfits/NA_pyfits.py 0644
These files start with #!/whatever but aren't executable.  For some reason,
python programmers like to start all of their files that way even when they
aren't supposed to be executable.  I have no idea why, but I've given up trying
to fix every package which does this.  If you want it to go away, strip the
first lines of those files in %prep:
  sed -i -e "1d" lib/NP_pyfits.py lib/NA_pyfits.py

Why does this require python-setuputils at runtime?

There is an included test suite.  If it's possible to run it at build time then
you should add a %check section.

* source files match upstream:
   a6b01c9d75e7955765019581700bd6ac344457b327522facedaf4cff9e86093c  
   pyfits-1.3.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
? not sure about the setuptools dependency:
   pyfits = 1.3-1
  =
   numpy
   python(abi) = 2.5
?  python-setuptools

? %check is not present, but there seems to be an included test suite.  I am not 
  sure how to run it.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.