[Bug 441186] Review Request: freenx-server - Free Software (GPL) Implementation of the NX Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freenx-server - Free Software (GPL) Implementation of the NX Server


https://bugzilla.redhat.com/show_bug.cgi?id=441186


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From kevin at tummy.com  2008-04-07 14:43 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv2)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
961913bb82ee6e60d8df6f10e647bda9  freenx-server-0.7.2.tar.gz
961913bb82ee6e60d8df6f10e647bda9 
../rpm/freenx-server-0.7.2/freenx-server-0.7.2.tar.gz
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
 
Issues:

1. Why have Release already at 6? This is a version bump from the old one,
so I would think it should be able to start again at 1?

2. rpmlint says:

freenx-server.src:20: E: hardcoded-library-path in /usr/lib/cups/backend
freenx-server.src:95: E: hardcoded-library-path in /usr/lib/cups/backend/nxsmb
freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver 0700
freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/db 0700
freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/db/closed 0700
freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/db/failed 0700
freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/db/running 0700
freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/home 0700
freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/home/.ssh 0700
freenx-server.x86_64: E: non-standard-dir-perm /var/log/nx 0700
freenx-server.x86_64: E: non-standard-uid /etc/logrotate.d/freenx nx
freenx-server.x86_64: E: non-standard-uid /etc/nxserver/node.conf.sample nx
freenx-server.x86_64: E: non-standard-uid /etc/nxserver nx
freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/db/closed nx
freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/db/failed nx
freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/db nx
freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/db/running nx
freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/home nx
freenx-server.x86_64: E: non-standard-uid
/var/lib/nxserver/home/.ssh/authorized_keys nx
freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/home/.ssh nx
freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver nx
freenx-server.x86_64: E: non-standard-uid /var/log/nx nx
freenx-server.x86_64: W: dangerous-command-in-%post mv
freenx-server.x86_64: W: dangling-symlink
/var/lib/nxserver/home/.ssh/authorized_keys /etc/nxserver/server.id_dsa.pub.key
freenx-server.x86_64: W: hidden-file-or-dir /var/lib/nxserver/home/.ssh
freenx-server.x86_64: W: hidden-file-or-dir /var/lib/nxserver/home/.ssh
freenx-server.x86_64: W: non-conffile-in-etc /etc/nxserver/node.conf.sample
freenx-server.x86_64: W: spurious-executable-perm
/usr/share/doc/freenx-server-0.7.2/nxsetup
freenx-server.x86_64: W: symlink-should-be-relative
/var/lib/nxserver/home/.ssh/authorized_keys /etc/nxserver/server.id_dsa.pub.key

All these can be ignored I think.

freenx-server.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/freenx

perhaps re-name the logrotate file to 'freenx-server' ?

Both of those issues are pretty minor, so if you could address them
before you import, that would be great. This package is APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.