[Bug 321411] Review Request: ski - IA-64 user and system mode simulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ski - IA-64 user and system mode simulator


https://bugzilla.redhat.com/show_bug.cgi?id=321411


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2008-04-07 19:21 EST -------
This is looking good.

You can get dir of the unused-direct-shlib-dependency complaints with another libtool hack:
  sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool
Since you're already hacking up libtool a bit, there's probably no reason not to do that as well (unless it breaks something, I guess).

The remaining rpmlint complaints are:

  ski-devel.x86_64: W: no-documentation
Not a problem.

  ski-devel.x86_64: W: no-dependency-on ski
The -devel package depends on the -lib package, but not the main package.  This also is not a problem.

Most packages seem to use "-libs" for the library subpackage, but there are a
few who use "-lib" and we don't seem to have any guidelines about it, so
that's OK.

There's a test suite in the "testsuite" directory; is this something which
could be run at build time?

Note that there's no need to include the COPYING twice.  Just having it in the
main package is sufficient, even if it's possible to install the software
without installing that package.  This isn't a blocker, though.

* source files match upstream:
  34b2a1b2575d6c8703df8f1f3980f7b668e744c4a03f20ed4ed91d40cf40c076  
  ski-1.3.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
? rpmlint has acceptable complaints, but a few are trivially fixed if you care
  to.
* final provides and requires are sane:
  ski-1.3.2-2.fc9.x86_64.rpm
   config(ski) = 1.3.2-2.fc9
   ski = 1.3.2-2.fc9
  =
   config(ski) = 1.3.2-2.fc9
   libICE.so.6()(64bit)
   libORBit-2.so.0()(64bit)
   libSM.so.6()(64bit)
   libX11.so.6()(64bit)
   libXext.so.6()(64bit)
   libXm.so.2()(64bit)
   libXp.so.6()(64bit)
   libXt.so.6()(64bit)
   libart_lgpl_2.so.2()(64bit)
   libatk-1.0.so.0()(64bit)
   libbonobo-2.so.0()(64bit)
   libbonobo-activation.so.4()(64bit)
   libbonoboui-2.so.0()(64bit)
   libcairo.so.2()(64bit)
   libelf.so.1()(64bit)
   libgconf-2.so.4()(64bit)
   libgdk-x11-2.0.so.0()(64bit)
   libgdk_pixbuf-2.0.so.0()(64bit)
   libglade-2.0.so.0()(64bit)
   libglib-2.0.so.0()(64bit)
   libgmodule-2.0.so.0()(64bit)
   libgnome-2.so.0()(64bit)
   libgnomecanvas-2.so.0()(64bit)
   libgnomeui-2.so.0()(64bit)
   libgnomevfs-2.so.0()(64bit)
   libgobject-2.0.so.0()(64bit)
   libgthread-2.0.so.0()(64bit)
   libgtk-x11-2.0.so.0()(64bit)
   libncurses.so.5()(64bit)
   libpango-1.0.so.0()(64bit)
   libpangocairo-1.0.so.0()(64bit)
   libpopt.so.0()(64bit)
   libski-1.3.so.2()(64bit)
   libxml2.so.2()(64bit)
   ski-lib = 1.3.2-2.fc9

  ski-devel-1.3.2-2.fc9.x86_64.rpm
   ski-devel = 1.3.2-2.fc9
  =
   /bin/sh
   libski-1.3.so.2()(64bit)
      ski-lib = 1.3.2-2.fc9

  ski-lib-1.3.2-2.fc9.x86_64.rpm
   libski-1.3.so.2()(64bit)
   ski-lib = 1.3.2-2.fc9
  =
   /sbin/ldconfig
   libXm.so.2()(64bit)
   libXt.so.6()(64bit)
   libelf.so.1()(64bit)
   libelf.so.1(ELFUTILS_1.0)(64bit)
   libglade-2.0.so.0()(64bit)
   libglib-2.0.so.0()(64bit)
   libgobject-2.0.so.0()(64bit)
   libgtk-x11-2.0.so.0()(64bit)
   libncurses.so.5()(64bit)
   libski-1.3.so.2()(64bit)

? %check is not present, but there's some sort of test suite included.
* Manual testing shows that things work at least partially, although I don't
  really know how to test this.
* shared libraries added; ldconfig is called properly.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files (besides the COPYING file)
* file permissions are appropriate.
* scriptlets are OK (ldconfig).
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.