[Bug 439345] Review Request: mediawiki-HNP - An extension to provide a hierarchical namespace permissions system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mediawiki-HNP - An extension to provide a hierarchical namespace permissions system


https://bugzilla.redhat.com/show_bug.cgi?id=439345





------- Additional Comments From josh.kayse at gtri.gatech.edu  2008-04-08 17:15 EST -------
I'll do a pre-review:

* source files match upstream:
   0e964e9273c606c46afbd311b5ad4d77
    3_01.txt
   7fc74905125cbfe4af78530e7db92583
    HNP-1.1.2.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
? package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   mediawiki-HNP = 1.1.2-1.fc9
  =
   mediawiki >= 1.10
   mediawiki-StubManager >= 1.1.0
 
* %check is not present; no test suite upstream.  I'm not sure how you would go 
  about testing this, anyway.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
? %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.