[Bug 441027] Review Request: openoffice.org-ooolatex - Support for embedded LaTeX in Impress/Writer documents

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openoffice.org-ooolatex - Support for embedded LaTeX in Impress/Writer documents
Alias: ooolatex

https://bugzilla.redhat.com/show_bug.cgi?id=441027


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




------- Additional Comments From tcallawa at redhat.com  2008-04-09 22:30 EST -------
Two items of concern:
1. pkg-licence/gpl_GB.txt should be in %doc. Please fix before committing.
2. Your release version isn't quite right. It should be:
Release: 0.2.beta2%{?dist}

Look closely at:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d2288206ac9bd8f1bf9b791b22a

Good:

- rpmlint checks return nothing
- package meets naming guidelines (except for Release)
- package meets packaging guidelines (OpenOffice.orgExtensions)
- license (GPLv2+) OK, matches source
- spec file legible, in am. english
- source matches upstream (928230a58c4d5678e579c78ea6ab6f0bf226d08b)
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Show me a spec with those items fixed, and I'll approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.