[Bug 441759] Review Request: mono-cecil-flowanalysis - Flowanalysis engine for Cecil

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mono-cecil-flowanalysis - Flowanalysis engine for Cecil


https://bugzilla.redhat.com/show_bug.cgi?id=441759





------- Additional Comments From alexl at users.sourceforge.net  2008-04-10 08:53 EST -------
 - Package meets naming and packaging guidelines: YES
 - Spec file matches base package name: YES
 - Spec has consistant macro usage: YES
 - Meets Packaging Guidelines: YES
 - License: YES, MIT,
http://anonsvn.mono-project.com/viewcvs/trunk/cecil/flowanalysis/README?view=markup
 - License field in spec matches: YES
 - License file included in package: YES, text included in README
 - Spec in American English: YES
 - Spec is legible.: YES
 - Sources match upstream md5sum:
No source upstream, only SVN.  Tried verifying the tarball, but it's only in
.tar.gz format, whereas the tarball in package is .tar.bz2, so won't match.
Should probably add comment in spec file about exactly which SVN revision used
as per http://fedoraproject.org/wiki/Packaging/SourceURL
 - Package needs ExcludeArch: YES, ppc64
 - BuildRequires correct: YES, mono-devel
 - Spec handles locales/find_lang: N/A
 - Package is relocatable and has a reason to be. N/A
 - Package has %defattr and permissions on files is good.: YES
 - Package has a correct %clean section.: YES
 - Package has correct buildroot: YES
    %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
 - Package is code or permissible content. YES
 - Doc subpackage needed/used.: N/A
 - Packages %doc files don't affect runtime. YES
 - Headers/static libs in -devel subpackage. N/A
 - Package is a GUI app and has a .desktop file N/A
 - Package compiles and builds on at least one arch: YES.  successful koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=560739

 - Package has no duplicate files in %files. YES
 - Package doesn't own any directories other packages own. YES
 - Package owns all the directories it creates. YES
 - rpmlint output:
mono-cecil-flowanalysis.i386: E: no-binary
mono-cecil-flowanalysis.i386: E: only-non-binary-in-usr-lib
these can be ignored as per 
http://fedoraproject.org/wiki/Packaging/Mono

 - final provides and requires are sane:

mono(Mono.Cecil) = 0.5.0.1
mono(mscorlib) = 1.0.5000.0
mono(Cecil.FlowAnalysis) = 0.1.0.0
mono-cecil-flowanalysis = 0.1-0.1.20080409svn100264.fc8

 no bogus provides there it appears, unlike certain other packages

SHOULD Items:

 - Should build in mock. YES (see koji build above)
 - Should build on all supported archs: YES (see koji)
 - Should have dist tag: YES
 - Should package latest version: YES (SVN version)

Issues:
1. Add comment in spec showing which exact SVN version used for this particular
 tarball as per:
http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a93a6cf030f2d08cf0d49

Fix this and I think I can approve.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.