[Bug 433219] Review Request: ganyremote - GTK frontend for anyremote

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ganyremote - GTK frontend for anyremote


https://bugzilla.redhat.com/show_bug.cgi?id=433219





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-04-10 14:25 EST -------
For 2.7-1:
* Spec file name
  - Spec file name must be ganyremote.spec .

* Requires
  - "pygtk2" has "Requires: python(abi) = 2.5" and
    "Requires: python >= 2.4" is not needed and should be removed.

  - /usr/bin/ganyremote has some extra dependency such as
-----------------------------------------------------------------
   222          ret = getResult('hcitool name '+data,'browser')
   250          elif (isInstalled('bluetooth-sendto') == 'OK'):
   251              sender = 'bluetooth-sendto --dest='
.....
-----------------------------------------------------------------
    Apparently ganyremote should have "Requires: bluez-utils"

* autotool call
  - build.log shows:
-----------------------------------------------------------------
    62  Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.30585
    63  + umask 022
    64  + cd /builddir/build/BUILD
    65  + cd ganyremote-2.7
    66  + LANG=C
    67  + export LANG
    68  + unset DISPLAY
    69  + rm -rf /var/tmp/ganyremote-2.7-1.fc9-root-mockbuild
    70  + make DESTDIR=/var/tmp/ganyremote-2.7-1.fc9-root-mockbuild install
    71  cd . && /bin/sh /builddir/build/BUILD/ganyremote-2.7/missing --run
aclocal-1.10 
    72  /builddir/build/BUILD/ganyremote-2.7/missing: line 54: aclocal-1.10:
command not found
    73  WARNING: `aclocal-1.10' is missing on your system.  You should only need
it if
    74           you modified `acinclude.m4' or `configure.in'.  You might want
    75           to install the `Automake' and `Perl' packages.  Grab them from
    76           any GNU archive site.
    77   cd . && /bin/sh /builddir/build/BUILD/ganyremote-2.7/missing --run
automake-1.10 --gnu 
-----------------------------------------------------------------
    Here autotools are called automatically, which is unwilling because
    this may change configure, makefiles in unwilling ways.
    This usually means that the timestamps of related files (i.e.
    configure{,in} etc) are wrong and this can usually be fixed
    by "touch"ing those files.

* desktop file directory
  - Don't install desktop files under other than %{_datadir}/applications

* desktop file Category
  - If you want that the group of this rpm should be "Applications/System",
    then the installed desktop file should have "System" category.

* Directory structure
  - Please move documents to under %_defaultdocdir (preferably 
    %_defaultdocdir/%name-%version, modification for %_bindir/%name is
    needed)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.