[Bug 442056] Review Request: mono-ndoc - Code Documentation Generator for .NET

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mono-ndoc - Code Documentation Generator for .NET


https://bugzilla.redhat.com/show_bug.cgi?id=442056


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-04-11 14:39 EST -------
rpmlint output is down to:
  mono-ndoc.x86_64: E: no-binary
  mono-ndoc.x86_64: E: only-non-binary-in-usr-lib
both of which are OK.

Everything looks good to me.

* source files match upstream:
   f587a11ff2b726347028faee8e1db654d1544cbdc8d37be593f0560ec8b60256  
   ndoc-devel-v1.3.1.zip
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
  mono-ndoc-1.3.1-2.fc9.x86_64.rpm
   mono(NDoc.Core) = 1.3.3023.0
   mono(NDoc.Documenter.JavaDoc) = 1.3.3023.0
   mono(NDoc.Documenter.Latex) = 1.3.3023.0
   mono(NDoc.Documenter.LinearHtml) = 1.3.3023.0
   mono(NDoc.Documenter.Msdn) = 1.3.3023.0
   mono(NDoc.Documenter.Msdn2) = 1.3.3023.0
   mono(NDoc.Documenter.Xml) = 1.3.3023.0
   mono(NDoc.ExtendedUI) = 1.3.3023.0
   mono(NDoc.Test) = 1.3.3023.0
   mono(NDoc.VisualStudio) = 1.3.3023.0
   mono(NDocConsole) = 1.3.3023.0
   mono-ndoc = 1.3.1-2.fc9
  =
   mono(NDoc.Core) = 1.3.3023.0
   mono(NDoc.ExtendedUI) = 1.3.3023.0
   mono(System) = 1.0.5000.0
   mono(System.Drawing) = 1.0.5000.0
   mono(System.Windows.Forms) = 1.0.5000.0
   mono(System.Xml) = 1.0.5000.0
   mono(mscorlib) = 1.0.5000.0

  mono-ndoc-devel-1.3.1-2.fc9.x86_64.rpm
   mono-ndoc-devel = 1.3.1-2.fc9
  =
   mono-ndoc = 1.3.1-2.fc9
   pkgconfig

* %check is not present.  As far as I can tell, tests are run at build time.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is all in the -devel package.
* %docs are not necessary for the proper functioning of the package.
* pkgconfig file is in the -devel package.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.