[Bug 434906] Review Request: xosview - OS resource viewer

bugzilla at redhat.com bugzilla at redhat.com
Sat Apr 12 10:46:59 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xosview - OS resource viewer


https://bugzilla.redhat.com/show_bug.cgi?id=434906





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-04-12 06:46 EST -------
Sorry for delay....

For 1.8.3-6
* About License tag
  - (BSD) license used in this tarball is what we call
    "BSD with advertising", which is _incompatible_ with (any version of)
    GPL and using "BSD with advertising"-only licensed codes cannot
    used for this package.

    Fortunately the only problematic codes are
    bsd/swapinternal.{h,cc} and they are not used for xosview.

    So:
    - Please change the license tag to "GPL+" (GPL at any version)
    - Don't add COPYING.BSD to %doc.

* Using CVS
  - If you want to use CVS:
    * Please follow the section "Using Revision Control" of
      http://fedoraproject.org/wiki/Packaging/SourceURL

    * and also follow
      http://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages

* Desktop file Category
  - The Category "Application" in desktop files are now deprecated
    and should be removed.

* Macros
  - Please replace:
    %_prefix/bin -> %_bindir
    %_prefix/share/man -> %_mandir

Well, as this is NEEDSPONSOR ticket:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list