[Bug 437285] Review Request: libgphoto2 - Library for accessing digital cameras

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgphoto2 - Library for accessing digital cameras


https://bugzilla.redhat.com/show_bug.cgi?id=437285





------- Additional Comments From j.w.r.degoede at hhs.nl  2008-04-14 08:22 EST -------
Full review done:

* This %define (luckily) does not seem to be used, please remove:
# Arches on which we need to prevent arch conflicts in gphoto2-config
%define multilib_arches %{ix86} ia64 ppc ppc64 s390 s390x x86_64

* I suppose this using 0.x scheme is only for the review, and you will jump to
  1%{?dist} after review?
Release: 0.1%{?dist}


* Source0: http://prdownloads.sourceforge.net/gphoto/libgphoto2-%{version}.tar.bz2

That is not the prefered form for a sf.net download url, that should be:

Source0: http://downloads.sourceforge.net/gphoto/libgphoto2-%{version}.tar.bz2


* Is this really needed? :
ExcludeArch: s390 s390x

I understand libgphoto is almost useless there, but it might be handy to still
have it so that applications which can use it don't have to have their specfiles
filled with %ifarch

* You should preserve the timestamps while converting the docs, so replace:
for i in AUTHORS COPYING; do
	cp ${i} ${i}.old
	iconv -f cp1250 -t utf-8 < ${i}.old > ${i}
	rm -f ${i}.old
done

with
for i in AUTHORS COPYING; do
	mv ${i} ${i}.old
	iconv -f cp1250 -t utf-8 < ${i}.old > ${i}
	touch -r ${i}.old ${i}
	rm -f ${i}.old
done

* License tag is wrong, the following source files are not LGPLv2+

GPLv2:
camlibs/adc65/adc65.c

GPLv2+:
camlibs/fuji/fuji.c
camlibs/minolta/dimagev/*
camlibs/mustek/*
camlibs/stv0680/*
libgphoto2/exif.c

LGPLv2:
camlibs/sipix/blink.c

So the correct license lines would be:
# GPLV2+ for the main lib (due to exif.c) and most plugins, some plugins GPLv2
License: GPLv2+ and GPLv2


* The descriptions need to be updated for the fact that this package now only
contains a lib and no longer the gphoto2 application.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.