[Bug 441570] Review Request: dnx - Distributed Nagios Executor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dnx - Distributed Nagios Executor


https://bugzilla.redhat.com/show_bug.cgi?id=441570





------- Additional Comments From xavier at bachelot.org  2008-04-14 13:50 EST -------
(In reply to comment #2)
> Okay, I think I've gotten all of these fixed, except the BuildRoot, which I
> don't believe was really in error -- it was copied and pasted directly from the
> packaging guidelines.
> 
Ok, my bad for the BuildRoot.


> Anyway, here's the fixed URLs:
> 
> Spec URL: http://neckbeard.info/packages/fedora/dnx.spec
> SRPM URL: http://neckbeard.info/packages/fedora/dnx-0.18-8.src.rpm
> 
> Thanks for the feedback.

The package doesn't build in mock. Changing :
%{__install} -d -m 0755 %{dnxrundir}
to
%{__install} -d -m 0755 %{buildroot}%{dnxrundir}
fixes it.

Once built, rpmlint output is not clean, mostly because of the strange %%defattr
of the %%files sections.
Also, please take care of the changelog. The release bumps from -1 to -7 and I
don't know what happened in between and the package actual release is -8 anyway.

The group creation is still not clean :
getent group %{dnxgroup} >/dev/null || groupadd -r GROUPNAME

Missing %post section :
%post
/sbin/chkconfig --add %{dnxsvc}



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.